The status indicator is a choice, and it is legible against a spent globe - #38
Merged
Conversation
…lobe ADDED: A Show the status indicator setting under General > Appearance, on by default; with it off the idle overlay is never mapped at all. CHANGED: The halo around the marker's text is light grey rather than black. - The globe behind it is dark whenever the mana is spent or fully reserved, which is exactly where a black outline disappeared. CHANGED: The halo's per-stamp alpha is solved back through the compositing rather than used directly. - The eight stamps blend over one another instead of adding, so a visible halo pixel lands at 1-(1-s)^n for the n of three a straight glyph edge gets. CHANGED: The update line is drawn at the same weight as the two state lines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
ADDED: The status indicator over the mana globe can be turned off, under Settings > General > Appearance. It is on by default, and turning it off changes nothing else about a price check.
CHANGED: The outline around the indicator's text is light grey instead of black, so it stays readable when the mana globe is dark — spent, or fully reserved.
Review notes
ADDED: A Show the status indicator setting under General > Appearance, on by default; with it off the idle overlay is never mapped at all.
CHANGED: The halo around the marker's text is light grey rather than black.
CHANGED: The halo's per-stamp alpha is solved back through the compositing rather than used directly.
1-(1-s)^nfor thenof three a straight glyph edge gets. Dividing by eight assumes additive blending and a coverage no visible halo pixel has.CHANGED: The update line is drawn at the same weight as the two state lines.
The grey and the alpha were tuned by eye on the maintainer's setup, where KWin's handling of a focused fullscreen game appears to wash the marker out; they are chosen to look right where compositing behaves and acceptable where it does not. Not investigated further.
🤖 Generated with Claude Code